Fix Dmail so that prior unread mail won't cause notice to appear #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrokenEagle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this bug recently due to leaving several Dmails unread for script testing purposes.
Basically, if you get a new mail and then hide the notice, it will set the ID to the most recent unread Dmail. However, if that message gets read, then it will no longer be the most recent unread, causing the prior ID equality check to fail, causing the user to get the unread mail notice even though there is no new mail.
So instead of checking for equality, it now checks for presence in case the cookie doesn't exist, then it checks that the most recent Dmail ID is greater than the cookie's value.