Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give option to make favorite groups public #3436

Merged
merged 2 commits into from Dec 19, 2017

Conversation

BrokenEagle
Copy link
Collaborator

Builds onto #3433 by giving the option to make favorite groups public. It also changes how the index search parameters are handled, showing only the public favorite groups instead of throwing a permission error.

@evazion
Copy link
Member

evazion commented Dec 19, 2017

#2424 also suggested this. IMO, though, favgroup visibility should be determined by the public/private flag alone. I suggest that the "privacy mode" account setting should only affect favorites, not favgroups.

As it stands, to make a single favgroup private, you'd have to opt-in to privacy mode, then opt-out of all your other favgroups being private. Also, it's not possible to make a single favgroup private without making your favorites private as well.

@r888888888 r888888888 merged commit a72e708 into danbooru:master Dec 19, 2017
@BrokenEagle BrokenEagle deleted the feat-public-favgroups branch December 21, 2017 20:00
@evazion evazion mentioned this pull request Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants