Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tumblr: pick biggest image based on resolution #4401

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

lllusion3469
Copy link
Collaborator

@lllusion3469 lllusion3469 commented Apr 8, 2020

photo[:alt_sizes] may contain a bigger image than
photo[:original_size]

fixes #4324

photo[:alt_sizes] may contain a bigger image than
photo[:original_size]

fixes danbooru#4324
@lllusion3469
Copy link
Collaborator Author

lllusion3469 commented Apr 8, 2020

There may be some tests that need to be fixed/added but I would have to set up and environment where I could actually run them first.

Update: tried to get rails test test/unit/sources/tumblr_test.rb test/unit/downloads/tumblr_test.rb to run on my local setup instead of using some complicated docker stuff and it insists on having archive_test set up. Also either rake db:create, rake db:migrate, or rails test deleted my whole public/data directory.

@evazion evazion merged commit cc31eea into danbooru:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 2048 Tumblr image links
2 participants