Add AsRef and AsMut implementation. #60
Conversation
src/lib.rs
Outdated
| @@ -396,6 +396,12 @@ impl Deref for Mmap { | |||
| } | |||
| } | |||
|
|
|||
| impl AsRef<[u8]> for Mmap { | |||
| fn as_ref(&self) -> &[u8] { | |||
There was a problem hiding this comment.
We could put an #[inline] attribute on these.
|
The build failure seems unrelated and might need an update of |
|
@KodrAus winapi 0.3 has some breaking changes, so this probably should be done in separate PR. |
|
Changes look good! I think it may just be a flake, so I'll re-run. Regardless I'm going to throw together a commit to move us to winapi 0.3 so should be fixed soon. Thanks! |
add AsRef and AsMut implementation
|
This has been released as part of 0.6.2. Heads up: I accidentally didn't push the 0.6.1 release commit/tag to github when I released it back in November, so the git history got out of wack with crates.io. Since crates.io is immutable, I opted to correct the history in GitHub and force push to the master branch. Shouldn't cause any issues, but you may need to reset your master branch if you've pulled since this commit landed. |
Hi! I wanted to use
Mmapbehind thestd::io::Cursorand gotthe trait std::convert::AsRef<[u8]> is not implemented for memmap::Mmap.