Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF: Fill in metadata #88

Closed
yashha opened this issue Nov 1, 2018 · 6 comments · Fixed by #107
Closed

PDF: Fill in metadata #88

yashha opened this issue Nov 1, 2018 · 6 comments · Fixed by #107
Labels
Feature New feature or enhancement Third-party

Comments

@yashha
Copy link
Contributor

yashha commented Nov 1, 2018

Would be useful.
puppeteer/puppeteer#3054
@yashha yashha changed the title Automatically fill meta date in pdf Automatically fill meta data in pdf Nov 1, 2018
@yashha
Copy link
Contributor Author

yashha commented Nov 1, 2018

Maybe use this
https://github.com/Sobesednik/node-exiftool#readme

@danburzo
Copy link
Owner

danburzo commented Nov 2, 2018

It'd be great if Puppeteer supported this feature. I'm not 100% sure whether node-exiftool can be used to write PDF metadata or EXIF data for images embedded in PDF files.

@danburzo danburzo added Feature New feature or enhancement Third-party labels Nov 2, 2018
@yashha
Copy link
Contributor Author

yashha commented Nov 2, 2018

Exiftool updates the exif/meta data of a file. I believe this is what I meant here.

I believe using this the right title would be displayed in the browser using my web api.
Also it would improve useability with programs like calibre.

Maybe we can suggest it in the puppeteer issue.

@yashha
Copy link
Contributor Author

yashha commented Nov 20, 2018

I created a feature request in chromium and puppeteer, this will take a while.
Shoud I create a pr with node-exiftool meanwhile for this repo or directly in my api server.
We can late still switch.

@danburzo
Copy link
Owner

That sounds good! If it works on your repo, I'll be glad to also merge it here.

@danburzo danburzo changed the title Automatically fill meta data in pdf PDF: Fill in metadata Jul 30, 2020
@danburzo danburzo mentioned this issue Sep 21, 2020
Closed
yashha added a commit to yashha/percollate that referenced this issue Sep 25, 2020
@yashha
danburzo#88 feature adds exif data to pdf file
53d7a73 
- it uses cli params or title and author of first document
- adds --author -a cli param for cover and exif data
yashha added a commit to yashha/percollate that referenced this issue Sep 25, 2020
@yashha
danburzo#88 cleanup duplicate title
6c5f238
@yashha yashha mentioned this issue Sep 25, 2020
Merged
yashha added a commit to yashha/percollate that referenced this issue Sep 25, 2020
@yashha
danburzo#88 adapt author assignment to code convention
0ddc782
yashha added a commit to yashha/percollate that referenced this issue Sep 28, 2020
@yashha
danburzo#88 use pdf-lib as exif editor
b51d88e 
because it is not execuable based
yashha added a commit to yashha/percollate that referenced this issue Sep 28, 2020
@yashha
danburzo#88 removed node exif
d3e12dd
danburzo pushed a commit that referenced this issue Sep 29, 2020
@yashha
#88 Feature: adds title / author metadata to PDF file (#107)
4d685ca
danburzo added a commit that referenced this issue Sep 29, 2020
@danburzo
Re: metadata in PDF (#88) and EPUB (#104)
5ff49bd 
* Use the Buffer returned by Puppeteer's pdf() method directly in PDFDocument
* Add author to EPUB and cover image
* Add --author to README
@danburzo
Copy link
Owner

Thank you for this, @yashha. I think pdf-lib works well enough that we don't depend on Puppeteer to add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or enhancement Third-party
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#88 feature adds exif data to pdf file yashha/percollate
2 participants
@danburzo @yashha