-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions to Tests/1153 #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, love it. Both the changes to PytestParameterEnum
and the new test cases.
if "id" in value: | ||
id = value["id"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice addition, also had it in mind! 😃
@@ -122,16 +122,9 @@ class InitcodeTestCases(PytestParameterEnum): | |||
"expected_storage": {0: 0x0000, 1: 0x0001}, | |||
} | |||
|
|||
def __init__(self, value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that the need for this boiler plate code is eliminated! Yet, it's still possible to modify/define new values in an optional __init__()
!
+ Op.SSTORE( | ||
0, | ||
opcode( | ||
Spec.TSTORE_GAS_COST + (PUSH_OPCODE_COST * 2) - 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
PytestParameterEnum
to make it a bit simpler to use, by adding aparametrize
method which automatically creates the parametrize decorator.