RFC/Pull request: Feature: save-to-file similar to append-to-file #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to append-to-file ',vp'. However when saving (using ',vf') you don't need to pass a filename. Instead, each message is saved to a different file. Message subject is used as filename. Invalid characters get replaced by underscores. This is most useful for me to save patch messages. TODO: Ask for confirmation? Ask for directory? Use message author also as filename? Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
|
Thanks for the patch. I'm still considering this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will never use append-to-file. Instead I'm using a modified version.
I believe it's more useful this way, perhaps it's useful to someone else.
Disclaimer:
I'm not a ruby developer, so I just copy-pasted code and used my brain a little.
Before this, I've never written a single ruby line.
So, feel free to modify the code...
Thanks!
Ezequiel.