Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable "sent" folder name and dynamic contacts export #169

Closed
wants to merge 3 commits into from
Closed

Configurable "sent" folder name and dynamic contacts export #169

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2014

One can now set the "Sent" mailbox name which enables multi lingual support for Gmail as well as for own server. Contacts are now extracted out of the configured sent folder.
Other configurable folder names will follow :)

@danchoi
Copy link
Owner

danchoi commented Apr 23, 2014

Thank you. I'll take a look this weekend.

@danchoi
Copy link
Owner

danchoi commented Apr 30, 2014

@mintao would you like to help me maintain this project? I would be happy to give you admin rights and let you merge things directly. Thanks for the patch!

@notalex
Copy link
Collaborator

notalex commented May 11, 2014

@mintao If the purpose of this PR is to display sent for non english Gmail accounts when viewing the mailbox list, then I do not think it is on the right track. I did not work for me when I tried it for my Hindi gmail account. This experimental branch might be what we should be working upon. It needs to be able to correctly compare the utf-8 encoded mailbox names.

@notalex
Copy link
Collaborator

notalex commented May 11, 2014

@mintao The experimental_branch can now alias all Gmail folder names(labels) for non English languages. I will be merging it into master soon. Let me know if this is what you need, so I that can close this PR.

@notalex
Copy link
Collaborator

notalex commented May 12, 2014

@mintao I understand now that this patch is specifically meant to address the issue #102 (unable to generate contacts file for non English accounts). Your code will require minor modifications to it to make it work with the multi_lingual patch which already deals with another issue related to non English mailboxes. Let me know if you are up for it and I will guide you through the modifications.

@notalex
Copy link
Collaborator

notalex commented May 19, 2014

@mintao I have fixed the issue with contacts generation and other reported problems with non English Gmail accounts in version 2.9.0. Some additional configuration will be required as documented in this wiki.

@notalex notalex closed this May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants