Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Switch from Travis to GitHub actions #396

Closed
dandavison opened this issue Nov 22, 2020 · 5 comments 路 Fixed by #418
Closed

馃殌 Switch from Travis to GitHub actions #396

dandavison opened this issue Nov 22, 2020 · 5 comments 路 Fixed by #418
Assignees

Comments

@dandavison
Copy link
Owner

Travis has been very useful to delta, but they recently changed their policies with the result that delta builds are not currently happening. I'm still waiting for them to tell me whether they'd like delta to switch to a paid plan or whether they're offering to support it as an Open Source project, but, it's probably time to switch to GitHub actions.

Since delta originally copied its Travis-based CI scripts from bat, it may help to consult the bat sources, since bat has since switched to GitHub actions: https://github.com/sharkdp/bat/blob/master/.github/workflows/CICD.yml

cc @MarcoIeni

@MarcoIeni
Copy link
Contributor

I will try to work on this :)

@dandavison
Copy link
Owner Author

I will try to work on this :)

That would be fantastic! Thanks @MarcoIeni!

@MarcoIeni
Copy link
Contributor

delta builds are not currently happening

Maybe it's because we have to update the path in https://github.com/dandavison/delta/blob/master/.travis.yml by the way 馃槄

@dandavison
Copy link
Owner Author

dandavison commented Nov 28, 2020

Oh, thanks! Fixed that symlink (4f167f4). But, I don't think that's it -- last build ran on 5th Nov whereas the bat dir rename was on 14 Nov (e527a69). I believe the issue is that Travis has changed their business model.

image

I have no criticism at all of them wanting to make some money; their support of open source projects was very generous. (It was a bit odd they didn't warn us though.) But Delta had been relying on their free support for open source projects, and I had been wanting to switch to Github Actions in any case.

@dandavison
Copy link
Owner Author

Do you think we should close this now @MarcoIeni?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants