Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Allow custom themes to be defined as light themes #598

Closed
kidonng opened this issue May 10, 2021 · 1 comment 路 Fixed by #617
Closed

馃殌 Allow custom themes to be defined as light themes #598

kidonng opened this issue May 10, 2021 · 1 comment 路 Fixed by #617

Comments

@kidonng
Copy link

kidonng commented May 10, 2021

Currently delta determines whether a theme is a light theme by checking it against a fixed list. This causes all custom themes considered dark themes, which is inconvenient as users have to supply a extra --light flag to make light themes work as expected.

Proposal: In additional to the fixed list, if a theme has "light" in its name, then consider it a light theme. This is not perfect but I don't know any dark theme having "light" in their name, so it should be fine :)

@dandavison
Copy link
Owner

Hi @kidonng, yep good call, this sounds reasonable, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants