Don't give up on parsing #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only if you have time, but any thoughts/opinions/sanity-checking etc here would be appreciated @m-lima! |
|
Merging this, comments still welcome at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @m-lima @gibfahn fixes #121 #100
This is a change to the parsing logic: instead of requiring that we detect the source diff type (git vs unified diff) from the first line, we keep trying to detect the source until we succeed. This causes diffs to be highlighted even when there is unrecognized initial material. Two tests are added for this sort of behavior, but one test is sacrificed -- involving non-diff input that looks diff-like.