Recognize GitHub SSH remote URLs that don't start with git@ for hyperlinks
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erlinks Closes dandavison#667. SSH remote URLs are usually formatted as `git@github.com:user/repo` but certain setups can allow using just `github.com:user/repo`, see issue dandavison#667 for an example. This modifies the regex used to detect a GitHub remote for hyperlink generation to also allow the latter form.
dandavison
approved these changes
Jul 26, 2021
Kr1ss-XD
added a commit
to Kr1ss-XD/delta
that referenced
this pull request
Jul 30, 2021
* upstream/master: Change example config in README Recognize GitHub SSH remote URLs that don't start with `git@` for hyperlinks (dandavison#668) Fix the empty result issue in add -p (dandavison#664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667.
SSH remote URLs are usually formatted as
git@github.com:user/repobut certain setups can allow using justgithub.com:user/repo, see issue #667 for an example.This modifies the regex used to detect a GitHub remote for hyperlink generation to also allow the latter form.