Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate process gracefully on error in diff() #685

Merged
merged 1 commit into from Aug 12, 2021

Conversation

dandavison
Copy link
Owner

@dandavison dandavison commented Aug 12, 2021

As noted in the comment in main(), process::exit should be avoided because it does not call certain destructors.

Fixes #681

As noted in the comment in main(), process::exit should be avoided
because it does not call certain destructors.

Fixes #681
@dandavison dandavison merged commit 35ba0dc into master Aug 12, 2021
@dandavison dandavison deleted the 681-no-process-exit branch August 12, 2021 20:17
Kr1ss-XD added a commit to Kr1ss-XD/delta that referenced this pull request Aug 12, 2021
* 'master' of github.com:dandavison/delta:
  Terminate process gracefully on error in diff() (dandavison#685)
  Update Dockerfile
  Bump bitflags from 1.2.1 to 1.3.1 (dandavison#682)
  Bump syntect from 4.5.0 to 4.6.0 (dandavison#674)
  clippy
  Ignore clippy needless_borrow lint failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 delta 0.8.3 leaves terminal in an inconsistent state on exit
1 participant