Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support insteadOf replacements in git remote URLs #694

Merged
merged 6 commits into from Aug 21, 2021
Merged

Conversation

dandavison
Copy link
Owner

Use libgit2 to query remote URL instead of querying remote.origin.url
directly. This has the consequence that insteadOf replacements are
honored.

See https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf

Fixes #693

Copy link

@mathstuf mathstuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should do it 👍

@dandavison dandavison changed the base branch from master to refactoring-for-693 August 21, 2021 01:32
Base automatically changed from refactoring-for-693 to master August 21, 2021 02:57
Use libgit2 to query remote URL instead of querying remote.origin.url
directly. This has the consequence that `insteadOf` replacements are
honored.

See https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf

Fixes #693
Use libgit2 to query remote URL instead of querying remote.origin.url
directly. This has the consequence that `insteadOf` replacements are
honored.

See https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf

Fixes #693
@dandavison dandavison merged commit a60652a into master Aug 21, 2021
@dandavison dandavison deleted the 693-remote-urls branch August 21, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Remote URL detection should parse insteadOf replacements
2 participants