Line numbers and side-by-side mode #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this feature enables line numbers, these can be disabled via the git config `delta.line-numbers=false`. So always enable line numbers, even if they do not print numbers. Construct more structs with ..Self::default()
|
Do you think this should be included in the next release, or does it not make user-facing changes because the assertion was a |
|
It also fixes a small layout bug in the side-by-side-without-line-numbers setup: In the right panel zero lines were 1 column shorter than diff lines. But I don't think anybody explicitly disables line numbers there, it's more for completeness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, line numbers CAN be disabled in side-by-side mode via the git config
delta.line-numbers=false(I noticed the env varGIT_CONFIG_PARAMETERSway too late). So take that into consideration, also blame more of the strangeness onUseFullPanelWidth.Additionally the spuriously incremented line numbers are fixed.