Update sysinfo version

[GuillaumeGomez]

In the new sysinfo version, I turned Pid into a newtype.

[dandavison]

Hi @GuillaumeGomez, thanks very much for doing this. It looks like there are some relevant test failures, but let us know if you'd like us to finalise the PR now.

[GuillaumeGomez]

Ah indeed! I'll fix the PR as soon as possible then.

[GuillaumeGomez]

The clippy lints seem buggy so just in case I put them into their own commit.

[GuillaumeGomez]

CI is happy! \o/

[dandavison]

Thanks @GuillaumeGomez. Would it also be an option for delta to work with native integer types, and only convert to the sysinfo::Pid type at the sites where delta is calling the library?

Perhaps another way of asking my question is -- I'm curious, can you explain why the sysinfo::Pid type needs to be used by clients of the sysinfo library, rather than being private to the library?

[GuillaumeGomez]

Thanks @GuillaumeGomez. Would it also be an option for delta to work with native integer types, and only convert to the sysinfo::Pid type at the sites where delta is calling the library?

Pid implements From where the conversion is from the native integer.

Perhaps another way of asking my question is -- I'm curious, can you explain why the sysinfo::Pid type needs to be used by clients of the sysinfo library, rather than being private to the library?

The problem is that this native type isn't the same on all platforms, making it complicated to write one code to handle all platforms at once. With this wrapping, it's now possible. I added a common fallback with from_u32 and as_u32, like that if you really need to work on the wrapped type, you can.

[th1000s]

What about moving all the Pid::from_u32(..) calls into MockProcInfo::with(..)?

[GuillaumeGomez]

What do you think @dandavison ?

[dandavison]

Yes, I'd also prefer to continue to use native integers where possible, and only wrap as sysinfo::Pid where necessary -- i.e. close to the library call boundaries.

[GuillaumeGomez]

Fine by me! Will sent an update as soon as possible.

[GuillaumeGomez]

I removed the sysinfo::Pid usage as much as possible, making the changes much smaller.

[dandavison]

Thanks a lot @GuillaumeGomez!