Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when hash is inner a value of a variable that escaped by quote #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bosure19
Copy link

@bosure19 bosure19 commented Jan 9, 2020

I found an issue in case of MYVAR="anyvalue#anyvalue" will be compute to "anyvalue instead of anyvalue#anyvalue. so we can't escape hash character

@coveralls
Copy link

coveralls commented Jan 9, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 8212d44 on bosure19:bugfix/escape-hash-on-quote into f699d03 on danday74:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 33bf94a on bosure19:bugfix/escape-hash-on-quote into f699d03 on danday74:master.

@toniopelo
Copy link

@danday74 Any chance we get this merged ?

@danday74
Copy link
Owner

danday74 commented Feb 6, 2024

OK the conflict seems fairly easy to resolve and coverage remains at 100%

But merging this won't publish it to npm

I haven't got time to publish to npm

If you give me your npm username then I can add you as a collaborator on npm and you can publish it yourself

Let me know if that works for you, if so I'll merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants