INFRASYS-6322 - Autoscaling down to original count when no new instan… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjkeller
force-pushed
the
INFRASYS-6322
branch
2 times, most recently
from
9493a6a
to
811f4eb
Compare
|
I did not see you make this change adam. I also made a change and I believe mine is more what we want. Instead of scaling down which would remove the old successful deployed in favor of the ones that the build thinks are broken it calls the revert code in L2D: #16 |
|
@jgostylo this situation only happens when we have more instance in auto-scale group that we expect to be there ALL running the same AMI. In this case, regardless of what caused the problem, we want decrease amount of instances, so we allow next deployment to proceed. |
|
+1 let merge this for now, and we can figure out better solution |
…ces are in the load balancer
adamjkeller
force-pushed
the
INFRASYS-6322
branch
from
811f4eb
to
db60964
Compare
|
+1 |
adamjkeller
added a commit
that referenced
this pull request
Nov 20, 2015
INFRASYS-6322 - Autoscaling down to original count when no new instan…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ces are in the load balancer
This will revert back to the original instance count if new instances come into the load balancer from the deployment but they aren't tagged with the new build.