(18.31.0) python 3 compatibility / drop python 2.6 support #42
Conversation
| @@ -4,8 +4,8 @@ | |||
| import argparse | |||
| from sys import exit, argv | |||
| from time import sleep, time | |||
| from AWSConn import AWSConn | |||
| from set_logging import SetLogging | |||
| from .AWSConn import AWSConn | |||
There was a problem hiding this comment.
Had a problem with running relative imports in python 2.6. This needs to be tested.
There was a problem hiding this comment.
you are correct, this was an issue initially.
I had to install pkg via pip to resolve vs git clone + execute py directly
setup.py
Outdated
| @@ -16,11 +16,13 @@ | |||
| tests_require = [ | |||
| "mock", | |||
| "boto", | |||
| "moto", | |||
| "moto==1.0.1", | |||
| "PyYaml", | |||
There was a problem hiding this comment.
moto has some problem with versions past 1.0.1?
There was a problem hiding this comment.
yeah, doesn't run on python2.6. this was the version of moto on the last successful run on travisci
tox.ini
Outdated
| commands= | ||
| {envbindir}/coverage run \ | ||
| -m pytest --basetemp={envtmpdir} {posargs} | ||
| {envbindir}/coverage html -d {toxinidir}/htmlcov/{envname} |
There was a problem hiding this comment.
do you want coverage erase for appveyor?
There was a problem hiding this comment.
no, was left over from copy
tox.ini
Outdated
| skip_missing_interpreters = True | ||
|
|
||
| [testenv] | ||
| usedevelop = true |
There was a problem hiding this comment.
Why do we want usedevelop? This would get us the development branches of our pip dependencies. also true ==True?
mayn
changed the title
mayn
changed the title
mayn
changed the title
mayn
changed the title
No description provided.