You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current ByteArrayResponseWrapper makes a bad assumption that .getWriter() is only ever used when calling a filter chain from the DandelionFilter.
The ByteArrayResponseWrapper should also override the following methods and either prevent them from going down to the wrapped delegate, or toss an exception if attempted to be used (indicating bad runtime assumptions in the filter chain)
sendError() - this commits the response and closes the connection
sendRedirect() - again, this commits the response, and you don't support it using servlet spec, you do it yourself
getResponse() - downstream shouldn't be allowed to unwrap to a base response object
getOutputStream() - use of this should not be allowed
flushBuffer() - this commits the response and should not be allowed when the DandelionFilter is being used
reset() - either implement this or declare it unsupported
resetBuffer() - either implement this or declare it unsupported
The text was updated successfully, but these errors were encountered:
joakime
changed the title
ByteArrayResponseWrapper should override more method to control response commit state
ByteArrayResponseWrapper should override more methods to control response commit state
Jul 22, 2016
The current ByteArrayResponseWrapper makes a bad assumption that .getWriter() is only ever used when calling a filter chain from the DandelionFilter.
The ByteArrayResponseWrapper should also override the following methods and either prevent them from going down to the wrapped delegate, or toss an exception if attempted to be used (indicating bad runtime assumptions in the filter chain)
The text was updated successfully, but these errors were encountered: