handle exceptions when writing frames

src/Proxy/writer_proxy.jl

@@ -23,12 +23,16 @@ struct WriterProxy <: IO
 end
 
 function run_writerproxy(w::WriterProxy)
-    for writerequest in w.channel
-        if writerequest == CloseSocket()
-            close(w.writer)
-            break
+    try
+        for writerequest in w.channel
+            if writerequest == CloseSocket()
+                break
+            end
+            write(w.writer, writerequest.frame)
         end
-        write(w.writer, writerequest.frame)
+    catch ex
+    finally
+        close(w.writer)
     end
 end
 

test/writer_proxy_test.jl

@@ -5,11 +5,20 @@ import DandelionWebSockets.Proxy: write, close
 struct MockWriter <: IO
     channel::Channel{Frame}
     closechannel::Channel{Bool}
+    exception::Nullable{Exception}
 
-    MockWriter() = new(Channel{Frame}(0), Channel{Bool}(0))
+    MockWriter() = new(Channel{Frame}(0), Channel{Bool}(0), Nullable{Exception}())
+    MockWriter(ex::Exception) = new(Channel{Frame}(0), Channel{Bool}(0), Nullable{Exception}(ex))
+end
+
+function write(m::MockWriter, frame::Frame)
+    if isnull(m.exception)
+        put!(m.channel, frame)
+    else
+        throw(get(m.exception))
+    end
 end
 
-write(m::MockWriter, frame::Frame) = put!(m.channel, frame)
 takeframe!(m::MockWriter) = take!(m.channel)
 close(m::MockWriter) = put!(m.closechannel, true)
 isclosed!(m::MockWriter) = take!(m.closechannel)
@@ -43,4 +52,14 @@ isclosed!(m::MockWriter) = take!(m.closechannel)
 
         @test isclosed!(mockwriter)
     end
+
+    @testset "Streams throws exception on write; Socket is closed" begin
+        writer = MockWriter(EOFError())
+        proxywriter = WriterProxy(writer)
+
+        frame = Frame(true, 0, 0, 0, OPCODE_TEXT, true, 1, 0, Vector{UInt8}(b"\x01\x02\x03\x04"), b"1")
+        write(proxywriter, frame)
+
+        @test isclosed!(writer)
+    end
 end