Withdraw announcement w/o healthy endpoints for TrafficPolicy Cluster

speaker/bgp_controller.go

@@ -111,11 +111,41 @@ func nodeHasHealthyEndpoint(eps *v1.Endpoints, node string) bool {
 	return false
 }
 
+func healthyEndpointExists(eps *v1.Endpoints) bool {
+	ready := map[string]bool{}
+	for _, subset := range eps.Subsets {
+		for _, ep := range subset.Addresses {
+			if _, ok := ready[ep.IP]; !ok {
+				// Only set true if nothing else has expressed an
+				// opinion. This means that false will take precedence
+				// if there's any unready ports for a given endpoint.
+				ready[ep.IP] = true
+			}
+		}
+		for _, ep := range subset.NotReadyAddresses {
+			ready[ep.IP] = false
+		}
+	}
+
+	for _, r := range ready {
+		if r {
+			// At least one fully healthy endpoint on this machine.
+			return true
+		}
+	}
+	return false
+}
+
 func (c *bgpController) ShouldAnnounce(l log.Logger, name string, svc *v1.Service, eps *v1.Endpoints) string {
-	// Should we advertise? Yes, if externalTrafficPolicy is Cluster,
-	// or Local && there's a ready local endpoint.
+	// Should we advertise?
+	// Yes, if externalTrafficPolicy is
+	//  Cluster && any healthy endpoint exists
+	// or
+	//  Local && there's a ready local endpoint.
 	if svc.Spec.ExternalTrafficPolicy == v1.ServiceExternalTrafficPolicyTypeLocal && !nodeHasHealthyEndpoint(eps, c.myNode) {
 		return "noLocalEndpoints"
+	} else if !healthyEndpointExists(eps) {
+		return "noEndpoints"
 	}
 	return ""
 }

speaker/bgp_controller_test.go

@@ -404,6 +404,86 @@ func TestBGPSpeaker(t *testing.T) {
 			},
 		},
 
+		{
+			desc:     "Endpoint list is empty",
+			balancer: "test1",
+			svc: &v1.Service{
+				Spec: v1.ServiceSpec{
+					Type:                  "LoadBalancer",
+					ExternalTrafficPolicy: "Cluster",
+				},
+				Status: statusAssigned("10.20.30.1"),
+			},
+			eps: &v1.Endpoints{},
+			wantAds: map[string][]*bgp.Advertisement{
+				"1.2.3.4:0": nil,
+			},
+		},
+
+		{
+			desc:     "Endpoint list contains only unhealthy endpoints",
+			balancer: "test1",
+			svc: &v1.Service{
+				Spec: v1.ServiceSpec{
+					Type:                  "LoadBalancer",
+					ExternalTrafficPolicy: "Cluster",
+				},
+				Status: statusAssigned("10.20.30.1"),
+			},
+			eps: &v1.Endpoints{
+				Subsets: []v1.EndpointSubset{
+					{
+						NotReadyAddresses: []v1.EndpointAddress{
+							{
+								IP:       "2.3.4.5",
+								NodeName: strptr("iris"),
+							},
+						},
+					},
+				},
+			},
+			wantAds: map[string][]*bgp.Advertisement{
+				"1.2.3.4:0": nil,
+			},
+		},
+
+		{
+			desc:     "Endpoint list contains some unhealthy endpoints",
+			balancer: "test1",
+			svc: &v1.Service{
+				Spec: v1.ServiceSpec{
+					Type:                  "LoadBalancer",
+					ExternalTrafficPolicy: "Cluster",
+				},
+				Status: statusAssigned("10.20.30.1"),
+			},
+			eps: &v1.Endpoints{
+				Subsets: []v1.EndpointSubset{
+					{
+						Addresses: []v1.EndpointAddress{
+							{
+								IP:       "2.3.4.5",
+								NodeName: strptr("iris"),
+							},
+						},
+						NotReadyAddresses: []v1.EndpointAddress{
+							{
+								IP:       "2.3.4.6",
+								NodeName: strptr("pandora"),
+							},
+						},
+					},
+				},
+			},
+			wantAds: map[string][]*bgp.Advertisement{
+				"1.2.3.4:0": {
+					{
+						Prefix: ipnet("10.20.30.1/32"),
+					},
+				},
+			},
+		},
+
 		{
 			desc: "Multiple advertisement config",
 			config: &config.Config{