Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit aggregate asset summaries to valid assets #1629

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

danlamanna
Copy link
Contributor

Fixes dandi/dandi-schema#183.

This should remove the encodingFormat errors we've been getting for a while. After this I'll manually trigger a re-aggregation for draft versions.

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we have any idea of how many "invalid" assets have already been aggregated? Just wondering if there will be a large difference in dandiset size noticeable by any users

@satra
Copy link
Member

satra commented Jun 19, 2023

@AlmightyYakob - the assets summary only includes metadata, not size, so it should not change either filecount or size.

@danlamanna danlamanna merged commit 7f418ed into master Jun 19, 2023
9 checks passed
@danlamanna danlamanna deleted the aggregate-valid-assets branch June 19, 2023 17:20
@dandibot
Copy link
Member

🚀 PR was released in v0.3.43 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DANDI-API-C7: aggregate_assets_summary_task: KeyError encodingFormat since Feb
4 participants