Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include APPROVED users for stats on homepage #1952

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aaronkanzer
Copy link

Cc @kabilar -- per our fix in LINC

The current query on the landing page that shows stats does not filter by user type (e.g. it takes in account REJECTED uers)

This PR includes the proper query.

@kabilar
Copy link
Member

kabilar commented Jun 4, 2024

Thank you, @aaronkanzer.

Hi @waxlamp, we noticed this behavior on lincbrain.org where the users count on the homepage included those users with a STATUS of APPROVED, PENDING, INCOMPLETE and REJECTED. Presumably the desired behavior is only to count the users who are APPROVED.

@kabilar kabilar requested a review from waxlamp June 4, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants