Refactor Ansible playbook to extract a separate Jupyterhub role #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asmacdo
commented
May 10, 2023
•
asmacdo
commented
- Ensure that no local paths are used (see comment below)
- Get the load balancer (metallb) working: https://kind.sigs.k8s.io/docs/user/loadbalancer/
- Add tests to the molecule
- Add CI workflow to trigger tests
- Add basic documentation on how to use this locally: initiate section Testing with the details in README.md
- Figure out deployment aspects before merging PR:
- Would it break existing hub if re-deployed?
(From roles/ dir)
=== Do not change lines below ===
{
"chain": [],
"cmd": "molecule init role dandi.jupyterhub --driver-name podman",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "roles"
}
^^^ Do not change lines above ^^^
yarikoptic
reviewed
May 16, 2023
| kubeconfig: "{{ lookup('env', 'KUBECONFIG') }}" | ||
| env: | ||
| KUBECONFIG: /home/austin/.kube/config-molecule-test | ||
| K8S_AUTH_KUBECONFIG: /home/austin/.kube/config-molecule-test |
There was a problem hiding this comment.
seems to have absolute paths and austin specific -- could be avoided ? may be at least via ~/ or $HOME?
There was a problem hiding this comment.
oops missed that one thanks
yarikoptic
reviewed
Jun 9, 2023
| License | ||
| ------- | ||
|
|
||
| BSD |
yarikoptic
changed the title
yarikoptic
reviewed
Jun 9, 2023
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| # TODO FIX THIS HACK | |||
There was a problem hiding this comment.
Suggested change
| # TODO FIX THIS HACK | |
| # TODO FIX THIS HACK: create proper vars definitions | |
| # They come from https://github.com/dandi/dandi-hub/blob/dandi/group_vars/all but only the ones | |
| # used in this playbook. |
|
Paused for now |
|
This is likely not necessary if we move forward with #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.