This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
changing the share icon #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiquito
suggested changes
Oct 14, 2021
There was a problem hiding this comment.
According to https://www.npmjs.com/package/vue-social-sharing, "twitter" ShareNetworks take two arguments:
hashtags A list of comma-separated hashtags.
twitter-user Twitter user to mention.
The original issue asked to remove the #dandi hashtag and replace it with the @DANDIarchive user.
|
@dchiquito - I believe should be better now |
|
@satra - could you please double check the twitter changes |
|
twitter looks good. could we also implement the other comment i had in the issue to use the share link in all viewports? |
|
ok, I moved the share icon to the title window |
mvandenburgh
approved these changes
Oct 14, 2021
|
@djarecka could you please merge this? If you'd like me to do it on your behalf, just let me know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #913