Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NWBInspector to the upload documentation #40

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

CodyCBakerPhD
Copy link
Contributor

@CodyCBakerPhD CodyCBakerPhD commented Mar 20, 2022

Hello everyone!

With the NWBInspector project converging on a final stable API, we're looking to start encouraging more widespread usage prior even to the early stages of DANDI validation. While these steps are technically optional right now, and dandi validation (also see PR #941) should catch any missing required metadata, we hope this should help improve the overall quality of NWBFiles that are ultimately uploaded.

Listing this in draft for the moment while we finalize a couple things on our side with regards to documentations and documentation links.

CC: @bendichter

Comment on lines 124 to 129
1. Thoroughly read through the NWBInspector report and try to address as many issues as possible.
Some autodetected violations, such as `check_data_orientation`, may be safely ignored in the event that the data is indeed confirmed to be in the correct form.
If the report is too large to efficiently navigate in your console, a report can be saved using

nwbinspector <source_folder> --report-save-path <report_location>.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps some suggestion to do this on a few files first before converting everything would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I've enhanced the description to reflect the ideal workflow (running on small amounts of data, and running the inspector as early in the process as possible, and as often as possible).

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review April 19, 2022 18:06
@satra
Copy link
Member

satra commented Apr 20, 2022

@CodyCBakerPhD - i'm going to merge this in, now that this is in the cli. also please see #42

@satra satra merged commit 932248f into dandi:master Apr 20, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the add_nwb_inspector_to_docs branch April 20, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants