Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub paradox #41

Merged
merged 8 commits into from
May 14, 2024
Merged

GitHub paradox #41

merged 8 commits into from
May 14, 2024

Conversation

mb706
Copy link
Collaborator

@mb706 mb706 commented May 13, 2024

A new version of paradox is upcoming that makes a few breaking changes. I will also need to update miesmuschel.

I try to make sure that most packages work with both the old as well as the new paradox, this would make updating smoother: first, all dependent packages update to something that works with both old and new paradox, and then paradox can finally be updated. I therefore changed the github actions script somewhat; this can be reverted when the new paradox is on CRAN.

The main change is that the Param class ceases to exist; instead, ParamSets are now constructed using the ps(x = p_int()) syntax. It also used to be possible to inspect the Param objects inside a ParamSet through $params, which does not work any more now.

I think the code does not use $params, so only a few instances of ParamSet$new( need to be changed.

@mb706
Copy link
Collaborator Author

mb706 commented May 13, 2024

(also ParamSet$subset() is no longer in-place)

@dandls dandls merged commit 0ed76f9 into main May 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants