Add merges and a few DF trinkets + Enchants + Legendary #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
Open
|
Ive gone through some issues and added merges for them. Lemme know how I can help. Id propose a generic merger: just merge all instances of the same spell (ID) within a certain time period (e. g. 1 GCD or 0.5 sec?) automatically without any configuration. Im not sure that I can do that yet (my LUA is very limited) :D |
|
thank you! I meant to get to this sooner, going to make a new beta release right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merges are checked by me using chars of myself, so they should be good.
I did not cleanup all the old IDs, maybe that should be done sometimes in the future?
Re: the DK Runes fix: it seems like the slot # is getting negative. Why? IDK, I just added the catch clause. It would be worth investigating why its getting negative though.
For the vigor change: Just adding this to the global array fixed the error, IDK what else would be necessary to properly add xct notifications for gaining a vigor charge.