This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Option _dynamicBase for an additional option type: 'function' #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daneden you should get back to this guy |
daneden
added a commit
that referenced
this pull request
Oct 15, 2015
Option _dynamicBase for an additional option type: 'function'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added another option type to enable the user to define the
_basevariable in even greater detail, as it was possible through the breakpoint map. Our production media queries are more than a simplemin-widthcomparison and I like the idea to have them only in the CSS file.Now one can compute the
_basethrough a user defined function on each execution. I know that this might slow down the script when used without caution (e.g. when usinggetComputedStyle()as in the given example). But on the other hand it was a useful edit to me and might also help others.