Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentMediaType for variants object #47

Merged
merged 4 commits into from Aug 15, 2022
Merged

Add contentMediaType for variants object #47

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
006f0ec
add contentMediaType for variants object
Aug 12, 2022
0d4c3a7
Assign contentMediaType to the appropriate variant property
Aug 12, 2022
91e556d
change content type to conform to UTType
Aug 14, 2022
b8760c6
Apply suggestions from code review
daneden Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/Types+Media.swift
View file
Open in desktop
@@ -1,4 +1,5 @@
import Foundation
import UniformTypeIdentifiers
daneden marked this conversation as resolved.
Show resolved Hide resolved

/// Media refers to any image, GIF, or video attached to a Tweet. The media object is not a primary object on any endpoint, but can be found and expanded in the Tweet object.
public struct Media: Codable, Identifiable {
Expand Down Expand Up @@ -95,7 +96,7 @@ extension Media {
public var bitRate: Int?

/// Type of media
public var contentType: MediaType
public var contentType: UTType
daneden marked this conversation as resolved.
Show resolved Hide resolved

/// URL to the media content
public var url: String
Expand Down