Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

songs in top rated dont play #621

Closed
addisflava opened this issue Jan 11, 2016 · 6 comments
Closed

songs in top rated dont play #621

addisflava opened this issue Jan 11, 2016 · 6 comments
Labels

Comments

@addisflava
Copy link

when you rate a song it shows up in the top rated list in home menu but when you click on it it says no data. but it works for albums but not for songs. the song shows up like an album but couldn't be played it says "no data"

@daneren2005
Copy link
Owner

I'm guessing you aren't using stock Subsonic? Only albums are supposed to show up there in the first place...

@addisflava
Copy link
Author

Am using madsonic. 5 .

@addisflava
Copy link
Author

It is it possible to add song rating . I realu dont understand why everything is center around album . I think top rated , most played stared feauters make more sence in songs more than albums . It is easy to remember an album browse to it . Madsonic has a lot of new features that support songs

@daneren2005
Copy link
Owner

<album id="7870" parent="7869" rank="0" isDir="false" title="Brandenburg Concerto No. 5 In" album="The Bach Collection" artist="Bach" track="1" year="1994" genre="Classical" coverArt="7869" size="14378880" contentType="audio/mpeg" suffix="mp3" duration="599" bitRate="192" path="Bach/The Bach Collection/Bach - Brandenburg Concerto No. 5 In D Major -Allegro 1.mp3" isVideo="false" userRating="5" averageRating="5.0" created="2013-12-05T10:19:11.000Z" albumId="518" artistId="372" type="music"/>

Mad in all his brilliance decided to make songs showed up labeled as albums breaking the default behavior.

@addisflava
Copy link
Author

Now the songs are displayed as songs but do not play , when u select a song it just jump to the next album , it is also very unorginized the way the songs and albums are displayed .

@daneren2005
Copy link
Owner

It actually is playing, it is just added later. The problem is due to the play after behavior. With just songs you click on a song and it starts at that song and adds all the songs after to the list to continue on after. It is pretty broken with albums in the list as well. It's never come before because everywhere else the albums are listed first then the songs. I will definitely fix it in the next release since the play after behavior doesn't even really make sense in a albums list anyways.

As for the ordering that is up to Madsonic. I can't just sort it albums then songs because I only load 20 at a time and just load more as you scroll down. I hope it's obvious why that wouldn't work with trying to apply my own sorting.

mikeyoism pushed a commit to mikeyoism/Subsonic that referenced this issue Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants