Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.4.4 byYear is backwards #967

Closed
lachlan-00 opened this issue Sep 26, 2019 · 4 comments
Closed

5.4.4 byYear is backwards #967

lachlan-00 opened this issue Sep 26, 2019 · 4 comments

Comments

@lachlan-00
Copy link

Dsub decades page From and toyear are backwards. Making it impossible to complete.

GET /rest/getAlbumList2.view?u=user&p
=enc:354764396f63784c52&v=1.2.0&c=DSub&size=20&offset=0&type=byYear&fromYear=2019&toYear=2010
@lachlan-00
Copy link
Author

I've worked around this in ampache develop by comparing both inputs.

Does dsub also always sen 1.2.0 as the version? I'm going to overwrite it to 1.13.0 which is the current ampache version

@daneren2005
Copy link
Owner

IIRC it does this because that is the way the Subsonic API returns the data. I believe that if you pass 2010 - 2019 to Subsonic, it returns the results as 2010, 2011, 2012, etc... If you pass 2019 - 2018, it goes 2019, 2018, 2017 which is what we want.

@daneren2005
Copy link
Owner

And yes it always sends the same version. The version in the API I believe is the oldest version that the client is designed to support. If we pass 1.14 to a server that is at version 1.13, it will return an error so the client knows it won't work correctly.

@lachlan-00
Copy link
Author

thanks for the clarifications

deluan added a commit to navidrome/navidrome that referenced this issue Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants