Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex support #177

Merged
merged 3 commits into from
Feb 16, 2018
Merged

Latex support #177

merged 3 commits into from
Feb 16, 2018

Conversation

rototor
Copy link
Contributor

@rototor rototor commented Feb 15, 2018

This is an addition to #161 - now also basic LaTeX formulars are supported. I've updated the feature documentation a little bit featuredocumentation.pdf.

Also the builder share now a common base class as many methods are just copy&paste as they mostly share the same settings.

To support LaTeX SnuggleTex is used. To do so I've created a FSDOMMutator interface, which can register callbacks to modify the W3C-Document before it is evaluated as HTML. For LaTeX the element text is converted into DOM nodes which are then appended as child. The real math rendering then happens using the MathML support.

I also added to the featuredocumentation the generation of a Table Of Content. But prepending this ToC to the document using content:element(toc) in an :after element seems not to work. But maybe I find another solution.

As always I you have better names for some classes, feel free to request changes.

@danfickle
Copy link
Owner

@rototor

This is excellent. My only query is adding the svg-support module as a dependency of the mathml module. Was this intended? Anyway, I’ll merge now and we can remove if unintentional.

@danfickle danfickle merged commit c584289 into danfickle:open-dev-v1 Feb 16, 2018
@rototor
Copy link
Contributor Author

rototor commented Feb 16, 2018

@danfickle MathML needs Batik (indirect through JEuclid). If there is a new Batik release, all modules using Batik should use the same version of Batik. The svg-support module specifies a Batik version, so I added it as dependency to "force" that Batik version on the other modules.

But using explicit dependency management in the parent pom.xml makes more sense.

=> You'll get a pull request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants