handle more gracefully an input without name attribute + select without option child #151 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjer
force-pushed
the
151-npe-form-missing-name-attribute
branch
from
324e667
to
72b50a4
Compare
|
A sincere thanks to @syjer for all these fixes to long standing issues! PS. I'm about to do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @danfickle , this PR handle more gracefully input/select/textarea elements without the name attribute.
Currently they launch a NullPointerException. With this PR, only a message at WARN level will be logged.
Additionally, I've added a more lenient handling for select elements without option child. (same NPE issue).
This fix issue #151