Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #302 #587

Merged
merged 6 commits into from
Oct 28, 2020
Merged

Fix #302 #587

merged 6 commits into from
Oct 28, 2020

Conversation

vipcxj
Copy link
Contributor

@vipcxj vipcxj commented Oct 23, 2020

All test passed except some faild without my commit as well.

@danfickle
Copy link
Owner

Hi @vipcxj,

Firstly, huge thanks for contributing to this project and fixing this longstanding bug! The code looks excellent.

As you will see, I made a few minor changes:

  • Moved your test to the automatic test runner that compares the result with known good proof.
  • Added a nested test, just to make sure it works similar to Chrome. It does!

Thanks again! I'll merge as soon as the CI server says OK.

@danfickle danfickle merged commit ed2bd9c into danfickle:open-dev-v1 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants