Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rtl numeric list #655

Merged
merged 3 commits into from
Feb 23, 2021
Merged

fix rtl numeric list #655

merged 3 commits into from
Feb 23, 2021

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented Feb 19, 2021 •
edited
Loading

Closes #645

johnnyaug and others added 3 commits February 19, 2021 18:12
@johnnyaug
fix rtl numeric list
3e4bd96
@johnnyaug
fix typo
5a50a96
@danfickle
danfickle#645 Add test for RTL counter list and couple of fixes.
e4fd98d 
+ Turns out bidi reordering is not needed as all list counters we currently generate are ltr ordered.
+ Add padding-right in default style-sheet at-least for the case where direction is set directly on the ol element.
+ Direction can be ltr, rtl or auto.
@danfickle
Copy link
Owner

Thanks heaps @johnnyaug,

I have added a commit with a test and a couple of fixes. Sorry, I led you astray with bidi reordering. Not required after all as all generated list markers are ltr anyway.

Thanks again and I will merge tomorrow unless you have any objections.

@danfickle danfickle merged commit 76b86d9 into danfickle:open-dev-v1 Feb 23, 2021
@johnnyaug
Copy link
Contributor Author

@danfickle thanks! Any chance we can release a version?

@danfickle
Copy link
Owner

I still want to fix #641 but hopefully I can release on weekend (2020-03-06ish). Thanks again @johnnyaug.

@danfickle danfickle mentioned this pull request Mar 19, 2021
Open
@danfickle
Copy link
Owner

1.0.7 finally released. Apologies for being very late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has passing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numbered lists: numbers rendered after text in RTL languages
2 participants
@johnnyaug @danfickle