Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix casing #14

wants to merge 2 commits into from

Conversation

xinbenlv
Copy link

@xinbenlv xinbenlv commented Oct 5, 2023 •
edited
Loading

Fixes #13

@xinbenlv
Copy link
Author

xinbenlv commented Oct 5, 2023 •
edited
Loading

Old Output:

npx eip712-codegen --input sampleTypes.js --entryPoints ReplayProtection > tmp/OldReplayProtection.so

New Output:

npm run build
node cli.js --input sampleTypes.js --entryPoints ReplayProtection > tmp/NewReplayProtection.sol

Both output are shared at https://gist.github.com/xinbenlv/55fe92093f53964233891bc19067a21e

image

@danfinlay
Copy link
Owner

Would you mind adding a test to prove the issue and that the change fixes it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackskar875 Blackskar875 Blackskar875 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The camelCase function was not called properly
3 participants
@xinbenlv @danfinlay @Blackskar875