Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix to mask in thermal_hist #1011

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Conversation

lchavez037
Copy link
Contributor

@lchavez037 lchavez037 commented Mar 22, 2023

Describe your changes
Typo fix to mask in thermal_hist.

Type of update
Is this a:

  • Update to documentation

Associated issues
Issue #999

Additional context
None

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@lchavez037 lchavez037 added the documentation Documentation issues or features label Mar 22, 2023
@lchavez037 lchavez037 added this to In progress in PlantCV3 via automation Mar 22, 2023
Copy link
Contributor

@JoeDuenwald JoeDuenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

JoeDuenwald

This comment was marked as duplicate.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1011 (bac2e47) into main (ecb4877) will not change coverage.
The diff coverage is n/a.

❗ Current head bac2e47 differs from pull request most recent head a05c05e. Consider uploading reports for the commit a05c05e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         141      141           
  Lines        6004     6004           
=======================================
  Hits         6003     6003           
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@JoeDuenwald JoeDuenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nfahlgren nfahlgren merged commit eaa2449 into main Mar 22, 2023
PlantCV3 automation moved this from In progress to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the Type_fix_Analyze_thermal_value branch March 22, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants