Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visualize_ovelay_two_imgs.md #1016

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

jmgordon1223
Copy link
Contributor

@jmgordon1223 jmgordon1223 commented Mar 22, 2023

Added .visualize to code block example to reflect the function being within the visualize sub-package

Describe your changes
Added .visualize to the example code block to reflect the function being within the visualize sub-package

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation<----
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?
#1016 ?
Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Added .visualize to code block example to reflect the function being within the visualize sub-package
@jmgordon1223 jmgordon1223 added the documentation Documentation issues or features label Mar 22, 2023
@jmgordon1223 jmgordon1223 added this to the PlantCV v4.x milestone Mar 22, 2023
@jmgordon1223 jmgordon1223 added this to Pull Requests in PlantCV4 via automation Mar 22, 2023
@jmgordon1223 jmgordon1223 self-assigned this Mar 22, 2023
@zeeuqsze zeeuqsze changed the base branch from 4.x to main March 22, 2023 17:52
@zeeuqsze zeeuqsze changed the base branch from main to 4.x March 22, 2023 17:53
@zeeuqsze zeeuqsze added this to In progress in PlantCV3 via automation Mar 22, 2023
Copy link
Contributor

@Stylopidae1793 Stylopidae1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1016 (fdd39f1) into 4.x (2aaa0f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              4.x    #1016   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         161      161           
  Lines        6833     6833           
=======================================
  Hits         6832     6832           
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit 77fe23a into 4.x Mar 22, 2023
PlantCV3 automation moved this from In progress to Done Mar 22, 2023
PlantCV4 automation moved this from Pull Requests to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the update-reflect-function-within-viualize-subpackage branch March 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
PlantCV4
  
Done
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants