Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1018 add install pytest cov to contribution guide #1024

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

maliagehan
Copy link
Member

@maliagehan maliagehan commented Mar 22, 2023

Describe your changes
Added pytest-cov install instructions for pr_review instructions

Type of update
Is this a:
update to documentation

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

updated to include pytest-cov install instruction.
@maliagehan maliagehan linked an issue Mar 22, 2023 that may be closed by this pull request
Copy link
Contributor

@jmgordon1223 jmgordon1223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1024 (9ac44bd) into main (9cd7e91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         141      141           
  Lines        6004     6004           
=======================================
  Hits         6003     6003           
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit 7f170eb into main Mar 22, 2023
@nfahlgren nfahlgren deleted the 1018-add-install-pytest-cov-to-contribution-guide branch March 22, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add install pytest-cov to contribution guide
4 participants