Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed an 'else: pass' from analyze_object #1036

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

joshqsumner
Copy link
Contributor

Describe your changes
Removed an else: pass section after an if area: which was suspected to be a problem line for code coverage checks.

Type of update
Is this a:

  • housekeeping

Associated issues
See #999

Additional context
None

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1036 (e0778f3) into main (28f66ee) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e0778f3 differs from pull request most recent head 6c68c98. Consider uploading reports for the commit 6c68c98 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1036      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         141       141              
  Lines        6004      6003       -1     
===========================================
  Hits         6003      6003              
+ Misses          1         0       -1     
Flag Coverage Δ
unittests 100.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/analyze_object.py 100.00% <ø> (+0.85%) ⬆️

@nfahlgren nfahlgren merged commit eac025b into main Mar 22, 2023
@nfahlgren nfahlgren deleted the analyze_objects-missingLineInCoverage branch March 22, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants