-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update roi_objects with Objects class #1037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1037 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 164 164
Lines 7004 7015 +11
=============================================
+ Hits 7004 7015 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JorgeGtz
changed the title
roi_objects docstring - modify objects params
update roi_objects with Objects class
Mar 23, 2023
JorgeGtz
added
ready to review
Objects class implementation
work in progress
Mark work in progress
and removed
work in progress
Mark work in progress
ready to review
labels
Mar 28, 2023
JorgeGtz
added
ready to review
and removed
work in progress
Mark work in progress
labels
Mar 28, 2023
nfahlgren
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Modify roi_objects to use instances of the Objects class instead of contours and hierarchies.
In this first step the function will only work with single ROIs. If provided with a multi-ROI Objects instance it shows a warning and only uses the first element. In order to use a multi-ROI Object, the user should iterate.
Type of update
Is this a:
Associated issues
#945
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md