Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update roi_objects with Objects class #1037

Merged
merged 11 commits into from
Apr 16, 2023

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Mar 22, 2023

Describe your changes
Modify roi_objects to use instances of the Objects class instead of contours and hierarchies.
In this first step the function will only work with single ROIs. If provided with a multi-ROI Objects instance it shows a warning and only uses the first element. In order to use a multi-ROI Object, the user should iterate.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
#945

Additional context

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1037 (c9edebc) into release-4.0 (662f488) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1037   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              164       164           
  Lines             7004      7015   +11     
=============================================
+ Hits              7004      7015   +11     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/report_size_marker_area.py 100.00% <100.00%> (ø)
plantcv/plantcv/roi_objects.py 100.00% <100.00%> (ø)

@JorgeGtz JorgeGtz changed the title roi_objects docstring - modify objects params update roi_objects with Objects class Mar 23, 2023
@JorgeGtz JorgeGtz added ready to review and removed work in progress Mark work in progress labels Mar 28, 2023
@HaleySchuhl HaleySchuhl self-requested a review April 11, 2023 12:12
@nfahlgren nfahlgren merged commit 09a26fa into release-4.0 Apr 16, 2023
5 checks passed
@nfahlgren nfahlgren deleted the update-roi_objects-w-objects-class branch April 16, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants