Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Objects class return Objects instance while iterating #1068

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Mar 22, 2023

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@JorgeGtz JorgeGtz added the work in progress Mark work in progress label Mar 22, 2023
@JorgeGtz JorgeGtz changed the base branch from main to release-4.0 March 22, 2023 20:30
@JorgeGtz JorgeGtz changed the title Make objects class recursive make Objects class return Object instance while iterating Mar 22, 2023
@JorgeGtz JorgeGtz changed the title make Objects class return Object instance while iterating make Objects class return Objects instance while iterating Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1068 (469f2e5) into release-4.0 (912c400) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-4.0    #1068   +/-   ##
============================================
  Coverage        99.98%   99.98%           
============================================
  Files              161      161           
  Lines             6851     6851           
============================================
  Hits              6850     6850           
  Misses               1        1           
Flag Coverage Δ
unittests 99.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/classes.py 100.00% <100.00%> (ø)
plantcv/plantcv/roi/roi2mask.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl self-requested a review March 22, 2023 20:56
@HaleySchuhl HaleySchuhl added update Updates an existing feature/method Objects class implementation labels Mar 22, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Mar 22, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Mar 22, 2023
@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Mar 22, 2023
@nfahlgren nfahlgren merged commit b6bf86f into release-4.0 Mar 22, 2023
PlantCV4 automation moved this from Pull Requests to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the make-Objects-class-recursive branch March 22, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants