-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace command-line scripts with console scripts #1099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfahlgren
added
enhancement
Enhancements to existing features
bugfix
Bug fixes
work in progress
Mark work in progress
labels
Mar 29, 2023
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1099 +/- ##
==============================================
Coverage 100.00% 100.00%
==============================================
Files 161 164 +3
Lines 6875 7004 +129
==============================================
+ Hits 6875 7004 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
added
ready to review
and removed
work in progress
Mark work in progress
labels
Mar 30, 2023
HaleySchuhl
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The currently included
plantcv-workflow.py
,plantcv-utils.py
, andplantcv-train.py
scripts do not work well on Windows systems. Additionally, the minimal code in these scripts are not tested (the important underlying code is already).This PR replaces these scripts with
cli
modules that are used to build installable programs (console scripts) at the time of installation. After installation the programs are now named:plantcv-run-workflow
,plantcv-train
, andplantcv-utils
.Type of update
Is this a: New feature or feature enhancement
Associated issues
Supersedes #617
Closes #616
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md