Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4.x #1142

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Update 4.x #1142

merged 4 commits into from
Apr 24, 2023

Conversation

nfahlgren
Copy link
Member

Describe your changes
Syncs changes in main to 4.x

Type of update
Is this a: update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review update Updates an existing feature/method labels Apr 24, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Apr 24, 2023
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1142 (8781fae) into 4.x (c946b8c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x     #1142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines         6857      6849    -8     
=========================================
- Hits          6857      6849    -8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/analyze_nir_intensity.py 100.00% <ø> (ø)
plantcv/plantcv/visualize/histogram.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit f0be5e0 into 4.x Apr 24, 2023
5 checks passed
PlantCV4 automation moved this from Pull Requests to Done Apr 24, 2023
@nfahlgren nfahlgren deleted the update-4x branch April 24, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants