Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threshold dual channels returning bad dtype #1144

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented Apr 25, 2023

Describe your changes
function threshold.dual_channels was returning a binary image of dtype depending on the type of max_value. By default and most of the time it returned a 64 bits image which is incompatible with the rest of PlantCV functions.

Type of update
Is this a:

  • Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@JorgeGtz JorgeGtz changed the base branch from main to 4.x April 25, 2023 20:18
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1144 (0036dca) into 4.x (f0be5e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x     #1144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines         6849      6852    +3     
=========================================
+ Hits          6849      6852    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 298785d into 4.x Apr 25, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the fix-threshold-dual-channels-returning-bad-dtype branch April 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants