-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add affine color correction function #1150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.x #1150 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 164 161 -3
Lines 7531 6890 -641
==========================================
- Hits 7531 6890 -641
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the color correction function based on an affine transformation in the RGB space (3D). The way this model affects the colors' dynamic is limited (see affine transformation) but it is less likely to create color artifacts.
Type of update
Is this a:
Associated issues
Additional context
The current color correction function is more flexible and can change the dynamics of the colors in more ways than using an affine model. The disadvantage is that this model can cause odd colors as a byproduct of better match the color card values.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md