Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affine color correction function #1150

Merged
merged 18 commits into from
May 15, 2023

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented May 4, 2023

Describe your changes
Added the color correction function based on an affine transformation in the RGB space (3D). The way this model affects the colors' dynamic is limited (see affine transformation) but it is less likely to create color artifacts.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues

Additional context
The current color correction function is more flexible and can change the dynamics of the colors in more ways than using an affine model. The disadvantage is that this model can cause odd colors as a byproduct of better match the color card values.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1150 (325ce28) into 4.x (298785d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               4.x     #1150    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          164       161     -3     
  Lines         7531      6890   -641     
==========================================
- Hits          7531      6890   -641     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/transform/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

@JorgeGtz JorgeGtz added new feature New feature ideas and solutions work in progress Mark work in progress labels May 5, 2023
@JorgeGtz JorgeGtz added ready to review and removed work in progress Mark work in progress labels May 12, 2023
@nfahlgren nfahlgren merged commit 250711e into 4.x May 15, 2023
5 of 6 checks passed
@nfahlgren nfahlgren deleted the add-affine-color-correction-function branch May 15, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants