Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warn cluster contour splitimg #1160

Merged
merged 3 commits into from
May 22, 2023

Conversation

zeeuqsze
Copy link
Contributor

@zeeuqsze zeeuqsze commented May 19, 2023

Describe your changes
Added warn function, replacing print statements.

Type of update
Is this a:

  • New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@zeeuqsze zeeuqsze added ready to review update Updates an existing feature/method labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1160 (9c07588) into release-4.0 (df9b956) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1160   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              167       167           
  Lines             7270      7268    -2     
=============================================
- Hits              7270      7268    -2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/cluster_contour_splitimg.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren changed the base branch from main to release-4.0 May 19, 2023 15:31
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation May 22, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone May 22, 2023
@nfahlgren nfahlgren merged commit 04724ec into release-4.0 May 22, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done May 22, 2023
@nfahlgren nfahlgren deleted the Add-warn-cluster-contour-splitimg branch May 22, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants