Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start function bound horizontal #1161

Merged
merged 19 commits into from
Jun 6, 2023
Merged

Conversation

JorgeGtz
Copy link
Contributor

@JorgeGtz JorgeGtz commented May 19, 2023

Describe your changes
Update function analyze bound to work with labels

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues
#945

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1161 (a6aa676) into release-4.0 (b7a9453) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-4.0     #1161    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files              168       170     +2     
  Lines             7351      7576   +225     
==============================================
+ Hits              7351      7576   +225     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/analyze/color.py 100.00% <ø> (ø)
plantcv/plantcv/analyze/size.py 100.00% <ø> (ø)
plantcv/plantcv/analyze/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/bound_horizontal.py 100.00% <100.00%> (ø)
plantcv/plantcv/analyze/bound_vertical.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation May 23, 2023
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone May 23, 2023
@nfahlgren nfahlgren added new feature New feature ideas and solutions work in progress Mark work in progress labels May 23, 2023
@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels May 24, 2023
@nfahlgren nfahlgren merged commit 774c225 into release-4.0 Jun 6, 2023
5 of 6 checks passed
PlantCV4 automation moved this from Pull Requests to Done Jun 6, 2023
@nfahlgren nfahlgren deleted the iterate-analyze-bound branch June 6, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants